Chiran

Had a look at sorting and it is potentially quite a big change. Maybe not totally impossible, but a lot of work and could involve making it a selection in .hta file as well as the plugin. So it can get a bit complex.

But something like what you proposed could be possible. I can have a look at it.

-Chiran

Alanis

Sorting on filename is fine. but would it be possible to also have the discription in the same box. As it is now you click on the filename and it shows the discription at the top. It would just be nice if it listed everything in the filename window also.

acdbac AC/DC back in Black
aerdrem Aerosmith Dream On

Then someone could edit the file and put what they want to show in the right line.

Chiran

That's good that it works now, and thanks for leading me to the bug I needed to fix.

And I do understand your point about naming and I have heard it before as well. So far I've reasoned that filename is usually more compact than the textual description. I also think it's a quite convenient method for sorting the songs. I don't think using the description would be better, since the naming conventions in descriptions vary as much if not more. However, I can investigate if it's easy to make it a user preference whether to display songs by filename or description.

-Chiran

Fortunis

Thought i would comment here, cos i got a little confused with Alanis's request.

What description?... Do you mean like this, in ConcerningHobbits.abc-

• N: "Concering Hobbits" by Howard Shore from "The Lord of the Rings: The Fellowship of the Ring" soundtrack.
• N: LotRO adaptation by Cranberry of the Mighty Mighty Bree Tones, Landroval server.

Surely thats too much info thats gonna be crowding the listbox in songbook.


I understand this, but its all down to the people making/uploading songs that are not labelled correctly with the information needed. i.e. instrument and time. Hate people placing their name in title of songs too.

Other than that you could edit them yourself for easier usage for yourself. Like i have with hundreds of abc files.

Song Title - Artist (if applicable) [Instrument] (time)

Is the format i stick to on all song parts i have. You could place all that info on the files names. so it shows it in the songlist if you wish.

Putting all parts together into 1 file is a must also, to keep the song list amount down and tidy.

-------------------

Great work Chiran

Alanis

The fix you linked to in your message works fine. The only request I have at this time is would be if you could show the song discription in the file list window. Its still hard to find what songs are unless you select them and then it does show at the top.

Chiran

The script (songbook.hta) parses information from inside the abc files and sometimes the files contain unexpected or weird stuff, which might break the database file since its format is supposed to be strict Lua code.

You can try to find out which file it is by removing some files and then generating the library again (and then reloading the plugin). Or you can also send your SongbookData.plugin file to me (chiran[at]theroadgoeson.org) and I can have a look at it.

Edit: On second look, the problem seems to be directory related. Could be that the plugin tries to load the directory list but it is empty? So in that case the problem might be caused by the songbook.hta file. The problem should still be evident in the SongbookData.plugin file.

-Chiran

Alanis

Here is the error message I get. I use alot of Plugins and have tried everything. I also tried deleting all songs and loading one at a time but no mater what one I try it still dont work. I do get the message the Song file is created and it does exist but the plugin still wont load.

...gs Online\Plugins\Chiran\Songbook\SongbookWindow.lua: 592: Index out of range.

Chiran

Something went wrong when I tried to update the plugin. Will be fixed soonish I hope .

Edit: Fixed.

-Chiran

Chiran

It's probably because of a problematic song file. You can try to remove all but few songs, generate the library and then start plugin. Repeating this process while adding songs back to the library can be used to find out which song file breaks the library.

Or you can also send the songbookdata.plugin file to me by email and I can have a look at it (to chiran(at)theroadgoeson.org).

I've tried to weed out these kind of errors but some always creep in. And since the data file is written in Lua, it is very prone to breaking.

-Chiran

Brode

i get this error when i load songbook and the button doesnt show up. Im sure ive done somethign wrong but i havent a clue what. I followed your instructions the best i could.

...gs Online\Plugins\Chiran\Songbook\SongbookWindow.lua: 1193: attempt to index field '?' (a nil value)
...gs Online\Plugins\Chiran\Songbook\SongbookWindow.lua: 1193: attempt to index field '?' (a nil value)

kickguy223

WOOT IT WORKED TY

Chiran

Yes, you need to make it then.

-Chiran

kickguy223

ok im at the documents but no plugins folder or do i have to make that?

Chiran

Hi,

The correct place for plugins is the same where screenshots are saved. The directory is usually at (Vista/W7) c:\Users\<winuser>\Documents\The Lord of the Rings Online\. Plugins should be in 'Plugins' subdirectory, so the whole path is c:\Users\<winuser>\Documents\The Lord of the Rings Online\Plugins\Chiran.

-Chiran

kickguy223

ok i looked at the link did what it says and checked were the files were suposed to be they looked corect to me so i went in game and typed /plugins refresh and said that i had no plugins so i did /plugins list to conform and said none for both loaded and not.
il give the area the .plugin file is in.

C:\Program Files (x86)\Turbine\The Lord of the Rings Online\browser\plugins\Chiran

plz respond asap