LoTROInterface : Combat Analysis : Combat Analysis

		LoTROInterface > LotRO Stand-Alone Plugins > Other
Combat Analysis

Page 3 of 15

Last »

Author

Comments

Comment Options

05-05-2022, 09:38 AM

gjpc

The Indomitable

Forum posts: 11

File comments: 85

Uploads: 4

Quote:

Not really sure what you mean, seems to me there are 2 shared brawler buffs at lines 120 and 121, which don't have localization for german that could possible cause the issue.

Can you give me the exact translation of

Code:

L["GetSerious"] = "Get Serious";
L["WeatherBlows"] = "Weather Blows";
L["SkipFree"] = "Skip Free";
L["IgnorePain"] = "Ignore Pain";
L["FollowMe"] = "Follow Me!";
L["QuickFeint"] = "Quick Feint";
L["OneforAll"] = "One for All";
L["SkipFree"] = "Skip Free";

Last edited by gjpc : 05-05-2022 at 09:53 AM.

05-05-2022, 09:06 AM

Drono

The Undying

Forum posts: 47

File comments: 107

Uploads: 1

Quote:

You are running down the right avenue Drono, but the error is a bit further on. If you look at the traits file you will see that the two Brawler buffs are empty entries. I am looking for the code that deals with the shared buffs. It is somewhere in there.

Not really sure what you mean, seems to me there are 2 shared brawler buffs at lines 120 and 121, which don't have localization for german that could possible cause the issue.

05-05-2022, 08:41 AM

gjpc

The Indomitable

Forum posts: 11

File comments: 85

Uploads: 4

Quote:

This is only on german client right? Looking on github, it seems the brawler buffs from recent patch were not translated and in CombatAnalysis/main.lua there is this

Code:

-- since English & German are supported at release, load their locale files directly
if (locale == "en" or locale == "de") then
  import ("CombatAnalysis.Locale."..locale);
-- for all other languages, we now load the English locale file first, then load the language specific file (which may only override some values) only if it exists
else
  import ("CombatAnalysis.Locale.en");
  pcall(import, ("CombatAnalysis.Locale."..locale));
end

it would probably fix the error if english locales were loaded before german too, as defaults for the missing so removing the 'or locale == "de"' from the line 21 to 'if (locale == "en") then' might fix the issues

Edit:It would mean the new buffs would probably not be tracked properly as they were not translated, but the plugin should work without errors.

05-05-2022, 08:31 AM

Drono

The Undying

Forum posts: 47

File comments: 107

Uploads: 1

This is only on german client right? Looking on github, it seems the brawler buffs from recent patch were not translated and in CombatAnalysis/main.lua there is this

Code:

-- since English & German are supported at release, load their locale files directly
if (locale == "en" or locale == "de") then
  import ("CombatAnalysis.Locale."..locale);
-- for all other languages, we now load the English locale file first, then load the language specific file (which may only override some values) only if it exists
else
  import ("CombatAnalysis.Locale.en");
  pcall(import, ("CombatAnalysis.Locale."..locale));
end

Last edited by Drono : 05-05-2022 at 08:33 AM.

05-05-2022, 05:14 AM

Gatros

The Wary

Forum posts: 0

File comments: 2

Uploads: 0

Error

Same here - same notice.
With Hunter and Runekeeper.

CA works with my champion and Burglar.

Last edited by Gatros : 05-05-2022 at 05:58 AM.

05-05-2022, 03:48 AM

heduda

The Wary

Forum posts: 0

File comments: 5

Uploads: 0

I could confirm the error messages with a hunter, captain, warden and minstrel.
German 64-bit-Client with CA 4.8.8 and 4.8.9 tried.

Additionally at Char-login there's a message from CA:
https://i.imgur.com/DgR632s.png

After this in chat is this message
https://i.imgur.com/x1k3u4J.png

And in fight this messages are produced
https://i.imgur.com/FFcGPTQ.png

Last edited by heduda : 05-05-2022 at 03:53 AM.

05-05-2022, 12:45 AM

bornfight

The Wary

Forum posts: 0

File comments: 43

Uploads: 0

Still have the error even in version 4.8.9. When I click on restore or reset properties the error is still there after a re log.
Have then times CA completely deleted including files in the chars and then reinstalled and this problem still occurs. With the same error messages.

05-04-2022, 02:19 PM

gjpc

The Indomitable

Forum posts: 11

File comments: 85

Uploads: 4

Quote:

I see this error with every class and I use version 4.8.8 and BuffBars 2.1.1.4. If I deactivate Combat Analysis I get no error, if CA is active then always when logging in.

Thanks for the report bornfight. I neglected to add the Brawler text entries to both the German and French files. 4.8.9 corrects this error.

05-04-2022, 01:22 PM

bornfight

The Wary

Forum posts: 0

File comments: 43

Uploads: 0

I see this error with every class and I use version 4.8.8 and BuffBars 2.1.1.4. If I deactivate Combat Analysis I get no error, if CA is active then always when logging in.

Chat:
I see this error with every class and I use version 4.8.8 and BuffBars 2.1.1.4. If I deactivate Combat Analysis I get no error, if CA is active then always when logging in.

Screen: https://ibb.co/GJ8r1PS

With this screen message you can do nothing else, only if you clicked on yes or no everything goes so far normally again up to the error message.

05-04-2022, 11:43 AM

gjpc

The Indomitable

Forum posts: 11

File comments: 85

Uploads: 4

error follow up

Quote:

Online\Plugins\CombatAnalysis\Parser\Parser.lua:46 : attempt to index global 'debuffApplications' (a nil value)

I get this error message in combat on all chars, since the last update.

I just ran a hunter, a brawler and a beoring. I did not see the error message. Are you using 4.8.8? If not please update. If you still see the error please tell me what class you are seeing it.

Thanks

05-04-2022, 02:54 AM

bornfight

The Wary

Forum posts: 0

File comments: 43

Uploads: 0

Online\Plugins\CombatAnalysis\Parser\Parser.lua:46 : attempt to index global 'debuffApplications' (a nil value)

I get this error message in combat on all chars, since the last update.

04-30-2022, 10:11 AM

Adra

The Undying

Forum posts: 171

File comments: 678

Uploads: 13

Quote:

mieux vaut tard que jamais, n'es pas d'accord ?

I agree

Last edited by Adra : 04-30-2022 at 10:13 AM.

04-30-2022, 09:40 AM

gjpc

The Indomitable

Forum posts: 11

File comments: 85

Uploads: 4

Quote:

I've quiclky checked the 4.8.6 fr.lua

Unfortunately, fellowship chat shortcut is not fixed, orc damage type is still missing, light damage french mistranslation into "légère" issue is not fixed.

This is a pity since I published those fixes 2 years ago in the comments, and also suggested an overall deeper translation since 2016

My file is probably not perfect but however more functional than the present one.

mieux vaut tard que jamais, n'es pas d'accord ?

04-30-2022, 07:45 AM

Adra

The Undying

Forum posts: 171

File comments: 678

Uploads: 13

Hello,

I've quiclky checked the 4.8.6 fr.lua

Unfortunately, fellowship and tribe chat shortcuts are not fixed, orc damage type is still missing, light damage french mistranslation into "légère" issue is not fixed.

This is a pity since I published those fixes 2 years ago in the comments, and also suggested an overall deeper translation since 2016

My file is probably not perfect but however more functional than the present one.

https://drive.google.com/file/d/1WS4...ew?usp=sharing

Last edited by Adra : 04-30-2022 at 10:19 AM.