LoTROInterface : BuffBars MaJ/Update 2017 patch fixes : BuffBars MaJ/Update 2017 patch fixes

		LoTROInterface > LotRO Patches
BuffBars MaJ/Update 2017 patch fixes

Page 2 of 2

Author

Comments

Comment Options

04-18-2024, 07:40 AM

b414213562

The Undefeated

Forum posts: 5

File comments: 109

Uploads: 13

Re: Mariner's

Quote:

Hi, b4!

I can't be sure this is a new problem possibly a result of today's release of u39.2 or if I somehow just didn't notice it earlier. However, any time I log in a Mariner character with the Motivated buff, or if I use the Mariner skill Motivating Song which grants the Motivated buff, I see this error:

-----
...ugins\PengorosPlugins\BuffBars\EffectBarSetting s.lua:144: attempt to index field '?' (a nil value)
-----

BuffBars won't load at all if the buff is present during login or plugin load. If the skill is cast to generate the buff during play, BuffBars continues to function but does not display the Motivated buff. The error message appears whenever the skill is cast during play as well as when the buff is present at the moment the character is logged in or the plugin attempts (and fails) to load.

I tested a lot of other buffs with both Mariner and other classes and did not note this issue other than with Motivated.

Thanks for reading!

edit: I have determined that the problem is not an issue with corrupted PluginData files by removing all files in *\PluginData and its nested folders that relate to BuffBars and the issue continues with identical symptoms with all settings at default values.

Hi there! This patch didn't change EffectBarSettings.lua, but I poked my head in the original code and it looks like if you add this line before the return statement on line 144, it could work around the problem:

Code:

function EffectBarSettings:GetRemainingColor(category)
    if (not self.colors[category]) then category = Colors.Undefined; end
    return self:GetColor(self.colors[category].remaining);
end

I'm guessing that effect has a category newer than BuffBars, which results in the error.

Good luck!

04-18-2024, 10:41 AM

JohnMHammer

The Indomitable

Forum posts: 14

File comments: 58

Uploads: 4

Re: Re: Mariner's

You're awesome! I spent hours yesterday looking through the code and that didn't stand out to me at all. I'll test this right away!

Just FYI, copying something I posted over on SSG's forums:
----- ----- ----- ----- -----
I have completed testing with all classes and I have noted this error with the Captain skill Motivating Speech/Improved Motivating Speech. I am not seeing this error with Telling Mark or Oathbreaker's Shame, most likely because these are debuffs on an enemy unit and not buffs on the casting character or the casting character's allies.

I have been as thorough as possible with my testing and I am seeing this issue with BuffBars only with the Mariner skill Motivating Song and its associated buff Motivated, and with the Captain skill Motivating Speech/Improved Motivating Speech and its associated buff Motivated (identical in name and effect to the buff applied by the Mariner skill).

Note that the buff In Defense of Middle-earth which is also applied by the Improved Motivating Speech skill does get properly displayed by BuffBars and does not appear to be contributing to any issues with the plugin.

So it does appear to be related to the change made in u39.1.2:

Quote:

Several Captain skill effects have been incorrectly stacking with similar effects from other classes that are meant to be mutually exclusive. These have been cleaned up, and should no longer stack, as expected. This includes Telling Mark & Marked Foes (Mariner), as well as Oathbreakers Shame, which was able to stack with The Breaking of Thangorodrim (Mariner) or Murder of Crows (Lore-master).

----- ----- ----- ----- -----

Last edited by JohnMHammer : 04-18-2024 at 10:42 AM.

04-18-2024, 11:20 AM

JohnMHammer

The Indomitable

Forum posts: 14

File comments: 58

Uploads: 4

Re: Re: Mariner's

Quote:

Code:

function EffectBarSettings:GetRemainingColor(category)
    if (not self.colors[category]) then category = Colors.Undefined; end
    return self:GetColor(self.colors[category].remaining);
end

I'm guessing that effect has a category newer than BuffBars, which results in the error.

Good luck!

While of course I could be making an error with my copy-paste, this appears to have no effect at all: The in-game behavior of BuffBars does not change with that line added to the EffectBarSettings.lua file above Line 144.

04-20-2024, 08:45 AM

Xaemyl

The Wary

Forum posts: 0

File comments: 13

Uploads: 0

Yeah I think it needs to be worked on a bit. It's also not reporting "Subscriber buffs" accurately since the latest patch. Edit: Ignore that last part. Once you refresh the sub buff, its correct again.

Last edited by Xaemyl : 04-22-2024 at 06:27 AM.

05-11-2024, 05:52 PM

JohnMHammer

The Indomitable

Forum posts: 14

File comments: 58

Uploads: 4

Patch available for Motivated buff bug

I have posted a patch for BuffBars which works around the Motivated bug which I explained earlier in the comments.

https://www.lotrointerface.com/downl...fo.php?id=1236

This file is a patch for the plugin BuffBars by Pengoros. BuffBars must be installed before this patch. There are two other patches for BuffBars and it is highly recommended that those patches get applied as well:
BuffBars MaJ/Update 2017 by Galphoglas
BuffBars MaJ/Update 2017 patch fixes by b414213562

LOTRO update 39.1.2 changed the category type for the buff Motivated which is applied by both the Captain skill Motivating Speech/Improved Motivating Speech and the Mariner skill Motivating Song. This change causes BuffBars to fail to load if the buff is active while the character is logged in or when the BuffBars plugin is loaded; and causes BuffBars to throw an error message and fail to display the Motivated buff if the buff is applied at some point after character login or plugin load.

This file is a replacement EffectItem.lua file. The easiest way to apply this patch is to download it, un-zip it, then drop the replacement EffectItem.lua file into your *\My Documents\The Lord of the Rings Online\Plugins\PengorosPlugins\BuffBars folder.

All credit goes to SSG LOTRO forum user Alaron who came up with the workaround for this problem. You can read his post on SSG's LOTRO forums here for details: https://forums.lotro.com/index.php?t...987/post-84343

Last edited by JohnMHammer : 05-12-2024 at 01:54 PM.

Page 2 of 2

Report this File | Recommend this file to a friend

Recommend this File

Search this Category:

All times are GMT -5. The time now is 10:54 PM.