Quantcast
lotrointerface.com
Search Downloads


Go Back   LoTROInterface > LotRO Stand-Alone Plugins > Bags, Bank & Inventory


Post A Reply
Author Comments Comment Options
Unread 12-05-2012, 11:22 PM  
Garan
The Undying
 
Garan's Avatar
Interface Author - Click to view interfaces

Forum posts: 294
File comments: 845
Uploads: 20
Quote:
Originally Posted by kryssie
uhh NO i did not paste in 3 lines, I edited line 607 and copied/pasted 606-609 so you could read all 3 lines and check the code.

So now we need a fix for line 610

code from 599-617

Code:
        self.SetLanguage=function()
        self.MoveUseDefault:SetText(Resource[language][302]);
    end
    self.EquipmentItemEquipped=function(sender, args)
    -- args are Index and Item
        self:SetWantsUpdates(true);
    end
    self.EquipmentItemUnequipped=function(sender, args)
        self:SetWantsUpdates(true);
    end
    self.RemoveCallbacks=function()
        self:Update=nil;
        if self.EquipmentItemEquipped~=nil then
            RemoveCallback(self.Equipment,"ItemEquipped",self.EquipmentItemEquipped)
        end
        if self.EquipmentItemUnequipped~=nil then
            RemoveCallback(self.Equipment,"ItemUnequipped",EquipmentItemUnequipped)
        end
    end
This is the code, could you check it please.

edit2: ahh i may have found it, shall reply with results xD
Well, I see what you did. In line 610 you changed the period to a colon. If you download 2.11b to a safe place like the desktop and open the zip file and inside that, open EquippedItemsPanel.lua you will see that line 610 was " self.Update=nil;" not " self:Update=nil;". It may seem like a trivial difference, but by changing that line, you were causing the error at 610.

Unfortunately, at this point, you may have added other minor but significant errors by editing parts of the file other than that in the original instructions. My recommendation is to download and install a fresh set of files using Lunarwater's Plugin Compendium. If you continue to get an error at line 205 (or any other line) then I would recommend that you do not use the plugin until I get 2.11c published.

Last edited by Garan : 12-06-2012 at 11:11 AM.
Garan is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-05-2012, 09:14 PM  
Kryssie
The Wary

Forum posts: 0
File comments: 4
Uploads: 0
a) I'm an idiot

b) I corrected the right file, but now it seems it won't load at all

I've uninstalled, then reinstalled a clean version, no editing and the icon doesn't come up lower left corner

Clean install and this is what I get in chat log

...ugins\GaranStuff\AltInventory\EquippedItemsPane l.lua:205: attempt to index global 'equipmentLayout' (a nil value)

When typing /plugins load altinventory it immediately crashed my client

I'm trying clearing out the char data and try again.

edit:

I give up it's all new files, freshly downloaded, I deleted all other data so it was a clean install and I just get the ...ugins\GaranStuff\AltInventory\EquippedItemsPane l.lua:205: attempt to index global 'equipmentLayout' (a nil value) error

I deleted everything on documents/lotro so no plugins folder etc
Created a new folder Plugins then pasted the Garanstuff/altinven folder inside, start the game and it gives the error.

Last edited by Kryssie : 12-05-2012 at 09:38 PM.
Kryssie is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-05-2012, 08:35 PM  
Kryssie
The Wary

Forum posts: 0
File comments: 4
Uploads: 0
Quote:
The error message you posted is showing line 610, not 607, so it appears that you added three lines with the correction, rather than just editing the line in place. It may be best to ignore the error for now since it does not prevent the rest of the plugin from working, just the Equipped Items view will be out of synch and it will get corrected when I get 2.11c published.
uhh NO i did not paste in 3 lines, I edited line 607 and copied/pasted 606-609 so you could read all 3 lines and check the code.

So now we need a fix for line 610

code from 599-617

Code:
        self.SetLanguage=function()
		self.MoveUseDefault:SetText(Resource[language][302]);
	end
	self.EquipmentItemEquipped=function(sender, args)
	-- args are Index and Item
		self:SetWantsUpdates(true);
	end
	self.EquipmentItemUnequipped=function(sender, args)
		self:SetWantsUpdates(true);
	end
	self.RemoveCallbacks=function()
		self:Update=nil;
		if self.EquipmentItemEquipped~=nil then
			RemoveCallback(self.Equipment,"ItemEquipped",self.EquipmentItemEquipped)
		end
		if self.EquipmentItemUnequipped~=nil then
			RemoveCallback(self.Equipment,"ItemUnequipped",EquipmentItemUnequipped)
		end
	end
This is the code, could you check it please.

edit2: ahh i may have found it, shall reply with results xD

Last edited by Kryssie : 12-05-2012 at 08:58 PM.
Kryssie is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-05-2012, 08:34 AM  
Garan
The Undying
 
Garan's Avatar
Interface Author - Click to view interfaces

Forum posts: 294
File comments: 845
Uploads: 20
Quote:
Originally Posted by Kryssie
Error is: ...ugins\GaranStuff\AltInventory\EquippedItemsPane l.lua:610: attempt to index field 'inventoryWindow' (a nil value)


What I edited in the file at line 607 (copied the segment just in case 606-608)
self.EquipmentItemUnequipped=function(sender, args)
self:SetWantsUpdates(true);
end

This what I get when swapping tools via the action bar.

Oh, and I logged to char select, altered the file, then loaded my char again.

Hmm nope no joy, can't seem to figure it out

Thanks for your help though, it's much appreciated
The error message you posted is showing line 610, not 607, so it appears that you added three lines with the correction, rather than just editing the line in place. It may be best to ignore the error for now since it does not prevent the rest of the plugin from working, just the Equipped Items view will be out of synch and it will get corrected when I get 2.11c published.
Garan is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-05-2012, 12:03 AM  
Kryssie
The Wary

Forum posts: 0
File comments: 4
Uploads: 0
Error is: ...ugins\GaranStuff\AltInventory\EquippedItemsPane l.lua:610: attempt to index field 'inventoryWindow' (a nil value)


What I edited in the file at line 607 (copied the segment just in case 606-608)
self.EquipmentItemUnequipped=function(sender, args)
self:SetWantsUpdates(true);
end

This what I get when swapping tools via the action bar.

Oh, and I logged to char select, altered the file, then loaded my char again.

Hmm nope no joy, can't seem to figure it out

Thanks for your help though, it's much appreciated

Last edited by Kryssie : 12-05-2012 at 12:25 AM.
Kryssie is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 08:25 PM  
Garan
The Undying
 
Garan's Avatar
Interface Author - Click to view interfaces

Forum posts: 294
File comments: 845
Uploads: 20
Re: Re: Re: 2.11b error in EquippedItemsPanel.lue

Quote:
Originally Posted by Kryssie
Quote:
Thanks for the feedback.

That's yet another bug introduced by attempting to rollback my 2.12 changes

Fortunately, this one is also simple to fix. If you want to fix your copy before I get the next update out, just find line 607 in EquippedItemsPanel.lua and change it from:
Code:
  self.inventoryWindow.ViewPanel[equippedItemsPanel]:SetWantsUpdates(true);
to
Code:
  self:SetWantsUpdates(true);
This is already fixed in 2.11c (I wasn't going to publish another interim release before 2.12 but there were enough bugs in 2.11b to probably warrant it).
I made these changes but I"m still receiving the error?
Hi. Lets try to unravel this mystery. Did you unload and reload the plugin after making the change? If so, did you check to be sure it is exactly the same error message? After removing the reference to "inventoryWindow" at line 607 you can not be getting an error from that reference so either the change was not correctly made or it is not the same error message.

If it is the same error message and you unloaded and reloaded the plugin (or restarted the client) then the only possibility left is that the change was not made correctly. I would advise starting over. After closing the client, redownload ver 2.11b, reextract it inside the Plugins folder and then edit the EquippedItemsPanel.lua file making sure that you are changing line 607 exactly as shown in the original post (removing the ".inventoryWindow.ViewPanel[equippedItemsPanel]" part), save the file and then restart the client.

If it is a different error message, please post the exact error message.

Last edited by Garan : 12-04-2012 at 08:26 PM.
Garan is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 07:25 PM  
Kryssie
The Wary

Forum posts: 0
File comments: 4
Uploads: 0
Re: Re: 2.11b error in EquippedItemsPanel.lue

Quote:
Quote:
Originally Posted by renbear
FYI, I'm getting the following error whenever I switch crafting tools (tailor's tools for forester's axe, etc)

...ugins\GaranStuff\AltInventory\EquippedItemsPane l.lua:607: attempt to index field 'inventoryWindow' (a nil value)

I believe I came across other errors on the same character before that one, but I can't remember what triggered them. I'll post again when I find them.

Unfortunately, I'm also using SortBag, so that may be getting in the way. Let me know if you need me to disable all other plugins, or if that error is informative enough.

PS: Thanks for making the effort to work around the Turbine-caused unload issue! It's good to have AltInventory back.
Thanks for the feedback.

That's yet another bug introduced by attempting to rollback my 2.12 changes

Fortunately, this one is also simple to fix. If you want to fix your copy before I get the next update out, just find line 607 in EquippedItemsPanel.lua and change it from:
Code:
  self.inventoryWindow.ViewPanel[equippedItemsPanel]:SetWantsUpdates(true);
to
Code:
  self:SetWantsUpdates(true);
This is already fixed in 2.11c (I wasn't going to publish another interim release before 2.12 but there were enough bugs in 2.11b to probably warrant it).
I made these changes but I"m still receiving the error?

Last edited by Kryssie : 12-04-2012 at 07:26 PM.
Kryssie is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 07:03 PM  
Garan
The Undying
 
Garan's Avatar
Interface Author - Click to view interfaces

Forum posts: 294
File comments: 845
Uploads: 20
Re: Re: Re: Re: Crash!

Quote:
Originally Posted by Renbear
Sorry, I didn't mean for it to sound like everyone should do that. It sounded like Art has possibly installed it to the wrong folder, or in a sub-folder, and "deleting the GaranStuff folder" is a sure-fire way to expose that.

You are, of course, correct that it would screw up other plugins, if he had more of yours installed.

My apologies.
No problem. You were just trying to help and that's the great thing about Lotrointerface, everyone is quite helpful. FWIW, to test an installation what I do is simply rename the entire Plugins folder to something like Plugins_old and then create a new Plugins folder in which I install just the plugins I'm testing and once I find the problem I remove the temporary folder, rename the old one and then implement any needed fix. I also usually back up the Plugins folder to a network drive as well, but not everyone has space to do that.
Garan is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 04:03 PM  
Garan
The Undying
 
Garan's Avatar
Interface Author - Click to view interfaces

Forum posts: 294
File comments: 845
Uploads: 20
Re: Still crashing

Quote:
Originally Posted by Artisez
I went through and completly removed all Alt Inventory. Re-installed the plugin and now the client crashes when I attempt to log in a toon.

Will chase down more infor on my syatem and get back with ya.
If you are having crashes on login, the first thing to do is to make sure Alt Inventory is not set to automatically load in the Plugin Manager - you can access the Plugin Manager from the character selection screen. If you client continues to crash on login, then the issue is not actually AltInventory - you might want to disable each of your autoloading plugins until the crash stops happening.

Once you can login without crashing, try using "/plugins load altinventory" from the command window. If the client crashes immediately then there is something broken in your installation and we will have to dig further.

Last edited by Garan : 12-04-2012 at 07:03 PM.
Garan is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 04:03 PM  
renbear
The Wary

Forum posts: 0
File comments: 6
Uploads: 0
Re: Re: Re: Crash!

Sorry, I didn't mean for it to sound like everyone should do that. It sounded like Art has possibly installed it to the wrong folder, or in a sub-folder, and "deleting the GaranStuff folder" is a sure-fire way to expose that.

You are, of course, correct that it would screw up other plugins, if he had more of yours installed.

My apologies.

Last edited by renbear : 12-04-2012 at 04:06 PM.
renbear is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 03:59 PM  
Garan
The Undying
 
Garan's Avatar
Interface Author - Click to view interfaces

Forum posts: 294
File comments: 845
Uploads: 20
Re: Re: Crash!

Quote:
Artisez,

Are you sure you have installed 2.11b? You might want to delete the old GaranStuff folder first to be CERTAIN you're not running the old version.

As far as I can tell, the old crash-on-logout problem is gone in 2.11b.
Actually, in the case of my plugins, you are usually safer leaving the existing files and just extracting over them. There was one exception to this, the thumbs.db file that got accidentally included in the zip files while I was temporarily publishing from a laptop when my regular dev machine died and required the users to remove the file before extracting. You also shouldn't remove the entire GaranStuff folder if you are running more than one of my plugins. You would at most want to delete the AltInventory folder inside the GaranStuff folder. Usually the simplest and safest way to update is using Lunarwater's Plugin Compendium.

As to the current round of crash reports, they seem to be occuring with people that are using more memory, other large plugins, larger texture caches, etc. so that is where I am focusing my testing efforts.
Garan is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 03:41 PM  
Artisez
The Wary
 
Artisez's Avatar

Forum posts: 0
File comments: 3
Uploads: 0
Still crashing

I went through and completly removed all Alt Inventory. Re-installed the plugin and now the client crashes when I attempt to log in a toon.

Will chase down more infor on my syatem and get back with ya.
Artisez is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 03:15 PM  
Artisez
The Wary
 
Artisez's Avatar

Forum posts: 0
File comments: 3
Uploads: 0
Will give it a go again. Thought I had removed it all but found another folder.

Thanks

Art
Artisez is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 03:04 PM  
renbear
The Wary

Forum posts: 0
File comments: 6
Uploads: 0
Re: Crash!

Artisez,

Are you sure you have installed 2.11b? You might want to delete the old GaranStuff folder first to be CERTAIN you're not running the old version.

As far as I can tell, the old crash-on-logout problem is gone in 2.11b.
renbear is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 12-04-2012, 02:52 PM  
renbear
The Wary

Forum posts: 0
File comments: 6
Uploads: 0
Re: Re: Crash!

There is a known* issue with Rohan and 32-bit installations of Windows. Something Turbine has done in that region causes an almost immediate crash upon entering it, but only on 32-bit XP, Vista or 7.

When trying to debug people's problems with your plugin, make sure the 32-bit problem isn't really the issue, and is thus completely outside your control.

Once again, Garan, thanks for all your work.

* Known to us, anyway. The developers haven't acknowledged it yet, but it's been verified by many people, and can be worked around with a boot.ini modification. Unfortunately, said modification often destabilizes the computer for other applications. :-( Even with the fix, LotRO will eventually crash.
renbear is offline Report comment to moderator   Reply With Quote Reply With Quote
Post A Reply

 
Category Jump:
Search this Category:
 

All times are GMT -5. The time now is 12:17 PM.


Our Network
EQInterface | EQ2Interface | Minion | WoWInterface | ESOUI | LoTROInterface | MMOUI | Swtorui