|
10-20-2012, 04:52 PM
|
|
The Wary
Forum posts: 0
File comments: 20
Uploads: 0
|
You probably dont need anyone else to say it, but since Update I crashed every time I tried to log off a char or exit the game. Now that I have disabled Altinventory, this doesn't happen.
Was a nice plugin, hope you can fix it.
Oh, and might as well be cheeky and ask if you can now enhance to pull in all the chars crafting recipes etc as this has been added to Rohan
|
|
|
10-18-2012, 09:58 PM
|
|
The Undefeated
Forum posts: 7
File comments: 69
Uploads: 0
|
Yes, my fix started failing on me, too. I removed the line and it fixed it for me, but I see it didn't fix other people.
I'm guessing that the problem is one of timing. The text for the message is stored in the space occupied by the plugin so if the chat server is busy, the space has been recovered before the text is referenced causing the crash.
"This is a fine mess you've gotten us into, Ollie"
Regards,
Brad
|
|
|
10-18-2012, 09:28 PM
|
|
The Wary
Forum posts: 0
File comments: 6
Uploads: 0
|
Still crashing, alas
FYI, I commented out the WriteLine in the unloadplugin function in main.lua, and it still crashes on unload for me.
|
|
|
10-18-2012, 02:24 PM
|
|
The Wary
Forum posts: 0
File comments: 13
Uploads: 0
|
Based on your guesses, Garan, I moved the Turbine.Shell.WriteLine from line 310 in Main.lua to line 280 (just after the function declaration). See the patch below. This eliminated the crash for me.
Brad
Code:
*** GaranStuff/AltInventory/Main.lua Wed May 16 14:05:18 2012
--- GaranStuff/AltInventory/Main.lua Thu Oct 18 09:39:25 2012
***************
*** 279,280 ****
--- 279,281 ----
function UnloadPlugin()
+ Turbine.Shell.WriteLine("AltInventory "..Plugins["AltInventory"]:GetVersion()..Resource[language][250]);
inventoryWindow:SetPluginUnloading(true);
***************
*** 309,311 ****
- Turbine.Shell.WriteLine("AltInventory "..Plugins["AltInventory"]:GetVersion()..Resource[language][250]);
-- reenable the built in bags
--- 310,311 ----
I made the above change and it did not fix the problem for me.
|
|
|
10-18-2012, 01:34 PM
|
|
The Wary
Forum posts: 1
File comments: 22
Uploads: 0
|
I crashed everytime I tried to do the session play with Boromir, 11 times in fact. When I read that AltInventory was causing this problem, I disabled said plug-in and had no more problems.
Hope you get this fixed as I love this plug-in.
Thanks for all your hard work
|
|
|
10-18-2012, 11:04 AM
|
|
The Undefeated
Forum posts: 7
File comments: 69
Uploads: 0
|
While looking at the code in Main.lua, I notice that the UnloadPlugin function reenables 5 bags after the comment " -- reenable the built in bags". There's now an optional 6th bag. I didn't make any guesses on how to adjust the code for the optional 4th, 5th, and now 6th bags (F2P starts with 3 bags). This is left as an exercise for the author!
|
|
|
10-18-2012, 10:57 AM
|
|
The Undefeated
Forum posts: 7
File comments: 69
Uploads: 0
|
Based on your guesses, Garan, I moved the Turbine.Shell.WriteLine from line 310 in Main.lua to line 280 (just after the function declaration). See the patch below. This eliminated the crash for me.
Brad
Code:
*** GaranStuff/AltInventory/Main.lua Wed May 16 14:05:18 2012
--- GaranStuff/AltInventory/Main.lua Thu Oct 18 09:39:25 2012
***************
*** 279,280 ****
--- 279,281 ----
function UnloadPlugin()
+ Turbine.Shell.WriteLine("AltInventory "..Plugins["AltInventory"]:GetVersion()..Resource[language][250]);
inventoryWindow:SetPluginUnloading(true);
***************
*** 309,311 ****
- Turbine.Shell.WriteLine("AltInventory "..Plugins["AltInventory"]:GetVersion()..Resource[language][250]);
-- reenable the built in bags
--- 310,311 ----
|
|
|
10-17-2012, 11:07 PM
|
|
The Undefeated
Forum posts: 7
File comments: 69
Uploads: 0
|
I have determined that for the plugins I use (see first code below), AltInventory is the one that causes the client to crash when I logoff or "Unload All" plugins. I have verified that with only AltInventory autoloading (see second code below), the crash occurs. I was testing near a Vault Keeper so I moved away and it still crashed. This is after the 8.0.1 patch.
I have posted a thread in the LOTRO General forum explaining how to determine which plugin is "guilty". I have also posted the first reply that says for me, AltInventory was the one. I am hoping that others will determine their "guilty" plugin, post it, and that the list of "guilty" plugins may help narrow down where the problem might be.
Code:
<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<PluginOptions>
<AutoloadOptions>
<Plugin AllCharacters="true" Name="Travel"/>
<Plugin AllCharacters="true" Name="AltInventory"/>
<Plugin AllCharacters="true" Name="DailyTasks"/>
<Plugin AllCharacters="true" Name="TonicBars"/>
<Plugin AllCharacters="true" Name="RaidAssistant"/>
<Plugin AllCharacters="true" Name="BuffBars"/>
<Plugin AllCharacters="true" Name="Palantir II"/>
<Plugin AllCharacters="true" Name="Crafting Companion"/>
</AutoloadOptions>
</PluginOptions>
Code:
<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<PluginOptions>
<AutoloadOptions>
<Plugin AllCharacters="true" Name="AltInventory"/>
</AutoloadOptions>
</PluginOptions>
Last edited by bsmorgan : 10-18-2012 at 12:09 AM.
|
|
|
10-17-2012, 09:11 AM
|
|
The Undying
Forum posts: 29
File comments: 34
Uploads: 2
|
Quote:
Currently, the only workaround is to manually unload the plugin before entering Session play - this may or may not cause a client crash, I have had success manually unloading.
|
Unfortunately, manual unloading also causes the crash, tho less often. In fact, a crash during manual unloading is how I figured out that it was Alt Inventory that was causing the crash.
Last edited by artificeren : 10-17-2012 at 09:12 AM.
|
|
|
10-17-2012, 08:00 AM
|
|
The Wary
Forum posts: 0
File comments: 3
Uploads: 0
|
Thanks for the update news; love your plugin!
|
|
|
10-17-2012, 07:12 AM
|
|
The Undying
Forum posts: 343
File comments: 981
Uploads: 20
|
For those having issues with the client crashing on unload -
This is a problem introduced in the RoR client and is affecting several plugins. I have not been able to determine what the exact cause is but it is very similar to other crashes we have seen in the past where Turbine fails to clean up event handlers that are released. I also encountered a similar crash on Bullroarer when writing to the chat window during the Plugin Unload event (AltInventory displays a message when unloaded) and I will be testing to see if this is related to the current issue. Unfortunately, for the same reason that a new release of AltInventory is on hold, I will not be able to do any in depth debugging for several more days.
Currently, the only workaround is to manually unload the plugin before entering Session play - this may or may not cause a client crash, I have had success manually unloading. If I determine that the chat message is indeed the problem then I will publish a hotfix based on the current version with no other updates in order to get a fix for this ASAP.
Unfortunately, it is likely that a permanent "correct" fix will require Turbine to update the client which may take a considerable amount of time.
|
|
|
10-16-2012, 01:41 PM
|
|
The Wary
Forum posts: 0
File comments: 11
Uploads: 5
|
Hi garan
I confirm the previous message.
I Love this plugin ^^
Clientcrash when unload; so not able to enter session play.
I have to disable it !!
|
|
|
10-15-2012, 08:52 PM
|
|
The Undying
Forum posts: 29
File comments: 34
Uploads: 2
|
Ya, let me also say that
1) Love the plugin
2) It's crashing the client on unload after the rohan update
|
|
|
10-15-2012, 07:24 PM
|
|
The Wary
Forum posts: 0
File comments: 1
Uploads: 0
|
Let me start by saying that I love this plugin; obviously a lot of work has gone into it. With that said, let us move on to the obligatory RoR-just-went-live bug report
With U8, It looks as though there's an unload problem resulting in a client crash (i.e. client crashes at character logout) It is possibly related to whether you're standing near enough to a vault keeper for the vault API to be available: I have one low level character nowhere near a vault and he can log out. He also has little or no AltInv information entered yet, including no Notes, so that may be a consideration as well.
Rather than try to debug this myself right now, I think I'll wait for the RoR LUA docs to be released (should be later this week, according to Turbine). It could be that they've changed something in the unload contract.
|
|
|
10-15-2012, 10:43 AM
|
|
The Wary
Forum posts: 0
File comments: 3
Uploads: 0
|
Just thought I'd post a quick thank you for the best plugin for LotRO! I can't wait for the new update with recipes!
|
|
|
All times are GMT -5. The time now is 08:45 AM.
|
|