LoTROInterface : VitalBars : VitalBars

		LoTROInterface > LotRO Stand-Alone Plugins > Unit Frames (Character, Fellowship, Target)
VitalBars

Page 3 of 6

Last »

Author

Comments

Comment Options

12-11-2010, 10:23 AM

xaero

The Wary

Forum posts: 0

File comments: 64

Uploads: 0

Played for hours last night w/ all of my plugins updated for the Nov. Patch. No issues! Which is good. I didn't encounter any of the issues described by MrJackDraw (neat ... I have a plugin of his (align (bevy didn't work for me in the past and tonicbars did so I stuck w/ that lol)).

Anyway, some suggestions. I know your busy and all. But do you have plans on expanding the Context-Sensitive menu to act more like a normal menu? Raid/Fellow sub-menu's, Target Marking, etc. Also 'Leave Group" and "Leave Instance" are *VERY* important! It's such a PITA to right click Vitals, check a box, then right click my default vitals portrait and 'Leave', then I have to hide it again. I know it's a simple thing to go and do this, I just see it as a waste of steps (I'm all about efficiency and streamlining what I do) and I'm usually the last one out of the instance because of all those extra steps.

Anywho just my $0.02...

12-11-2010, 10:19 AM

MrJackdaw

The Undying

Forum posts: 249

File comments: 422

Uploads: 19

Code:

My day is pretty packed tomorrow (Saturday) but I should be able to get to this in late afternoon or early evening and have a new version up tomorrow night or in the wheee hours of Sunday morning.

Don't worry about it! Similar things happen to all of us - we just appreciate what you are doing!

12-11-2010, 08:18 AM

Cylver

The Wary

Forum posts: 0

File comments: 7

Uploads: 0

Thank you so much for updating this. It's such a straight forward, simple addon, however I find it very difficult to play without - one of my favorite addons by far!

12-11-2010, 04:13 AM

Faflaf

The Indomitable

Forum posts: 14

File comments: 26

Uploads: 1

Quote:

Getting;

Code:

...f the Rings Online\Plugins\Faflaf\VitalBars\Main.lua:7: Unable to resolve package "Turbine.Utils"

I know how demoralising this can be when the bugs start to hit! Did you unload the old Turbine folder when you put in the new one, as Turbine.Utils has been removed.

EDIT: Confirmed - if I remove the import lines for Turbine.Utils in two files (I forget which!) the plugin seems to work just fine.

EDIT: Just made my usual changes - everything worked fine. Then I noticed;

Code:

...ings Online\Plugins\Faflaf\FormElements\CheckBox.lua:65: attempt to index field 'base' (a nil value)

And now I get

Code:

...Rings Online\Plugins\Faflaf\VitalBars\VitalsMenu.lua:8: attempt to index global 'optionsWindow' (a nil value)

every time I right click for options...

And I have no idea what change I made, sorry! By the way - I really, really like this plugin and thank you for the hard work!

EDIT: Changing the following lines fixed the plugin for me;

line 65 in FormElements/Checkbox

from;

Code:

self.base.SetSize(self, width, height);

to;

Code:

self.label.SetSize(self, width, height);

Changing line 213 in FormElements/Slider;
from;

Code:

self.base.SetSize(self, width, height);

to;

Code:

self.slider.SetSize(self, width, height);

Thanks for all the info. Just checked my file system and I still have Turbine.Utils, sorry missed that one, which looks like it will cause issues when ppl grab the new Turbine stuff.

All the code in the FormElements directory is stuff I proudly copied from Buffbars (from the UI directory if anyone cares) so I will grab the latest version of Buffbars and do a file compare on those files I copied into VitalBars and see if there are enough changes to require a new copy or if the mods you suggest are all that's necessary.

My day is pretty packed tomorrow (Saturday) but I should be able to get to this in late afternoon or early evening and have a new version up tomorrow night or in the wheee hours of Sunday morning.

12-11-2010, 12:41 AM

MrJackdaw

The Undying

Forum posts: 249

File comments: 422

Uploads: 19

Getting;

Code:

...f the Rings Online\Plugins\Faflaf\VitalBars\Main.lua:7: Unable to resolve package "Turbine.Utils"

Code:

...ings Online\Plugins\Faflaf\FormElements\CheckBox.lua:65: attempt to index field 'base' (a nil value)

And now I get

Code:

...Rings Online\Plugins\Faflaf\VitalBars\VitalsMenu.lua:8: attempt to index global 'optionsWindow' (a nil value)

Code:

self.base.SetSize(self, width, height);

to;

Code:

self.label.SetSize(self, width, height);

Changing line 213 in FormElements/Slider;
from;

Code:

self.base.SetSize(self, width, height);

to;

Code:

self.slider.SetSize(self, width, height);

Last edited by MrJackdaw : 12-11-2010 at 03:33 AM.

12-10-2010, 08:10 PM

xaero

The Wary

Forum posts: 0

File comments: 64

Uploads: 0

I restarted my client and buffbars started working again w/ Feenixx's little patch, might have been something on my end. As for the error I posted, I don't actually use the turbine vitals bar, I mean I did at first, but haven't for a long time now. So I dunno why that showed up. I just grabbed your update and updated my plug-in. Gonna hit Hele tonight w/ my kin, will let you know if I run into any problems.

**EDIT** So far, things look well, lotro's Vital plug-in was check (but it shouldn't have been, so I dunno why it was showing up ... I guess when I saw Vitals, I didn't look closely enough and assumed it was this plug-in

Last edited by xaero : 12-10-2010 at 08:33 PM.

12-10-2010, 07:59 PM

Faflaf

The Indomitable

Forum posts: 14

File comments: 26

Uploads: 1

Wonders never cease - I finally got a new version uploaded.

I put the fix in for the November patch and did my full round of testing and didn't find any other problems. Please let me know if something breaks.

The only added feature I got into this release was allowing the 3D background to have it's height adjustable. Because LOTRO doesn't have the ability to "stretch" a background I had to create various sized background images and then apply the appropriate one based on a size dropdown in the options window. Let me know what you think of this implementation.

Sorry I didn't get a new version uploaded last night like I had planned. I worked on getting the adjustable height features done til 1am. By that time I was introducing more bugs than I was fixing so I waiting til today to finish it up.

I also verified VitalBars works with BuffBars.

Last edited by Faflaf : 12-10-2010 at 08:03 PM.

12-10-2010, 05:28 AM

Feanixxx

The Wary

Forum posts: 0

File comments: 2

Uploads: 0

I'm using Buffbars and the Vitalbars that I adjusted together with no problems. I'm about to download the new Vitalbars that Faflaf has updated, I'll let you know if I have any problems.

Edit: Whoops, just noticed that Faflaf hasn't posted the new version yet, my bad. However, I can confirm that Vitalbars with my two changes works fine with the following:
Altinventory
Buffbars
KragenBars

All are loaded in via a shortcut to Manager with Vitalbars at the bottom of the list.

Last edited by Feanixxx : 12-10-2010 at 05:40 AM.

12-10-2010, 01:37 AM

Faflaf

The Indomitable

Forum posts: 14

File comments: 26

Uploads: 1

Re: Re: November Update Fix

Quote:

While this did indeed work, it stopped BuffBars from loading. When I load Manager, I get the following error.

Code:

...nline\Plugins\TurbinePlugins\Vitals\VitalsWindow.lua:112: attempt to call field 'LocalPlayer' (a table value)

It's my understanding that this is a bug in how LOTRO implements LUA. I don't know if this will actually get fixed, so now I need to choose what to use, VitalBars or BuffBars (but it looks so damn sexy when they are used together).

I took a second look at the error you posted and noticed that the error is with the TurbinePlugin call Vitals and not with VitalBars. While VitalBars is based on the Turbine Plugin there is no dependancy between the two. I haven't looked into the code yet but I'm guessing your error is caused because the Turbine plugin Vitals has not been modified and is still using .LocalPlayer() and not .LocalPlayer:GetInstance(). Sadly, I am still downloading and installing the November patch so I won't be able to fully test VitalBars with Buffbars for a bit. Update Game Data is still at 1%

12-10-2010, 01:19 AM

Faflaf

The Indomitable

Forum posts: 14

File comments: 26

Uploads: 1

oh thats not good

oh man, Buffbars and Vitalsbars not working together really sucks. I use buffbars and even recommend it in the plugin description above.

12-09-2010, 09:09 PM

xaero

The Wary

Forum posts: 0

File comments: 64

Uploads: 0

Re: November Update Fix

Quote:

Originally Posted by feanixx

Until the author updates this plugin, the following will fix Vitalbars for the November Update.

Go to the plugins folder:
My Documents\The Lord of the Rings Online\Plugins\Faflaf\VitalBars\
(Your path may differ)

Edit the folling two files (you can use notepad):

Filename: VitalsMenu.lua

Change Line 5 from:
local NameItem = Turbine.UI.MenuItem(Turbine.Gameplay.LocalPlayer() :GetName(), false );

To:
local NameItem = Turbine.UI.MenuItem(Turbine.Gameplay.LocalPlayer.G etInstance():GetName(), false );

Filename: VitalsWindow.lua

Change Line 49 from:
self.player = Turbine.Gameplay.LocalPlayer()

To:
self.player = Turbine.Gameplay.LocalPlayer.GetInstance()

You should now find that Vitalbars works fine with the November update.

Edit: Ignore the space in 'G etInstance' for some reason it won't go away, it should be 'GetInstance' of course.

While this did indeed work, it stopped BuffBars from loading. When I load Manager, I get the following error.

Code:

...nline\Plugins\TurbinePlugins\Vitals\VitalsWindow.lua:112: attempt to call field 'LocalPlayer' (a table value)

12-09-2010, 06:00 PM

Faflaf

The Indomitable

Forum posts: 14

File comments: 26

Uploads: 1

How often does Turbine break their API

I was just wondering if Turbine breaks plugins with API changes with every patch? This is the main reason I stopped developing my own Addons (and now don't use any) for WoW. I was hoping Turbine would be smarter about how they scaled their LUA support.

12-09-2010, 05:53 PM

Faflaf

The Indomitable

Forum posts: 14

File comments: 26

Uploads: 1

I'm still alive

I'm still around I just haven't had time to sit down at my PC for several weeks now. I will put the fix in for the Nov. patch tonight and get it uploaded.

If all goes well there will be a couple new features as well.

Last edited by Faflaf : 12-09-2010 at 05:55 PM.