Matsack

Sorry for absence..

To be honest, i liked the plugin functions, but didn't install the plugin to test it when i wrote first post.
Now i have, and sure it's doing, what CA and Buffbars have a hard time doing. GREAT WORK !!
Haven't tried this out in raid, but sure work flawlessly in instances.

Thank you for your effort

Myrthian

Looking good so far: I see you used my idea to hide health/power to make it similar to buffbars, but for dots/debuffs.

Another round of suggestions from me:
- You're using the title bar to access the context menu which means there is no possibility to completely hide the bar itself to just display debuffs/dots? Would it be possible to minimize the bar + hide the name of the target?
- Quite a few abilities are missing like Trick: Dust in the Eyes from burglar. I you want I can try to compile a list of abilities you're still missing
- Would it be possible to disable the names of the debuffs/dots and just display the icon with the timer, akin to buff monitor?
- How about progress bars like buff monitor, maybe you can borrow the how-to from there?
- I reckon the sorting of effects in the option window is still on your to-do list
- No idea if it's feasible, but a toggle icon/shortcut for the window would be a nice QoL addition: show it while you're in an instance, hide it when you're out

I'm unsure what the lock icon is supposed to do: I though it would be there to lock the frame, which isn't the case, and instead it's used for a target lock.

What is the frame position used for?

Tekko

When I use Barbed Arrow on my hunter, the debuff does not display.

I have to untarget the mob, then target it again for it to show.

edit: Just to add, if I use Pen Shot afterwards it shows.

Grimmerthan

@Matsack : you're welcome, and thanks for your appreciation. I consider CA, BuffBars, and this plugin to be complimentary. Each do different and valuable things.

Grimmerthan

My responses are:
[1] Quite possible. This would probably remove right-click context menu interaction with whatever is targeted, to expose the plugin's menu instead. Maybe I can put up a straw poll to get some wider feedback on some of these. I'll think about how to do that.
[2] Absolutely lots are missing. Please make sure these are actually effects on a target though, and not skills or buff. If you could screenshot the tooltip of the effect on the mob, this would be perfect.
[3] Yes, would be small effort. If another layout is also being requested, then not small effort.
[4] I've been thinking about progress bars and flashing. I may lift some more code from BuffBars (thanks a lot!) to speed this along. There's much more infrastructure in that code though, and I'd hope to keep it light, code-wise.
[5] Yes.
[6] Very feasible. I was thinking a CLI command to toggle visibility though, but you're talking about what StatWatch and Epic Battle Plugin have.
[7] It locks onto a target, so one can maintain an easy-click target to multiple different mobs.
[8] It saves the location of all frames, so when reloaded, the same count, positions, and effects come up. Another step towards making instance/boss/situation specific setups, where one saves and loads repeatable used setups.

Grimmerthan

Yep, this is how the Lua interface works here. In this situation, the first time there's an effect, the bleed isn't in the list returned through Lua. The next time the list is returned, either by a target refresh or by an effect coming or going, the bleed is in the list.

For solo play, where there are few effects coming and going, it won't shine. Take it into an instance though, and it handles far better.

Myrthian

LM:
- Ancient Craft is only properly registered once you cast a spell on the target
- Ice-Lore/Fire Lore: the 2nd Lore spell cast won't be recognized until you cast a spell on the target, or sometimes not at all
- Benediction of the Raven also suffers from the same issue

Hunter:
- Barbed Arrow only showing after hitting an enemy with another attack

Cappy:
- Is it possible to get an approximation for Standard of War e.g. a counter that counts towards 30 once the use of Standard gets logged in the combat log?
- Using Revealing and Telling Mark in succession causes the frame to display both debuffs as ongoing, even though only 1 is active on the target

Warden is the only one I'm not too familiar with, so no information about missing debuffs from me.

For the other classes I should've gotten most if not all missing debuffs.
https://www.sendspace.com/file/pwaw4r

If you want to display most of them in the list you run into the problem of the list becoming massive: maybe you can opt for something like Buffmonitor does with hiding options behind a clickable frame, in this case a separate category if you will for each class, and effects sorted by debuff or dot.

gelly

Any chance we might be able to adjust font size?

Grimmerthan

Hi Myrthian,

Thanks a lot for the legwork! Let me unpack this a bit:
- 1st effects not recognized until a 2nd effect (LM and Hunter)
-- Yes, this is the Lua interface. It's buggy. I can't make it operate better. I keep saying this File a bug with SSG and post to Lotro forums about it?
- Cappy - standard of war
-- This is a buff and not an effect on an NPC. This is not yet part of what DebuffVitals does. When(/if) this is extended to include effects on PCs, then sure. It wouldn't track log output though.
- Cappy - double marks
-- This is a problem with tracking toggled effects. Because of the buggy Lua response, DebuffVitals isn't able to tell the difference between "mark there but not in the returned list" and "no effect at all". This is handled by a timeout on toggled effects, and missing effects will disappear after a few seconds.
- Lots of effects
-- I don't have a good answer for this. Let's see if some ideas or a direction becomes more clear after some more changes.

Grimm

Grimmerthan

Ooh! Yah, good idea. I skipped it when I was duplicating m_vitals, and I should put it on the list now.

Lisgrat

Hey.
If you take someone to the target, block using the lock, and then click on any empty space on the screen, the chat starts without end spamming error 478. Spam happens exactly until you remove the lock. Sometimes a similar error spam and without a lock. Just in battle. Spam will stop if you change the target or update the current one.
Plugin settings are the simplest: display only Morale. No effects are displayed, Power is also hidden.

Also, I noticed that the FPS starts to fall very strongly when monitoring only 5 debuffs of RK's (dots). If the plugin is disabled and good old Vitals returns, there is no drawdown of the FPS.


https://prnt.sc/mmtpn1

Grimmerthan

I think I've fixed this. I suspect this should have been seen before and wasn't reported, or my recent changes exposed something.

This is a good example of the plugin trying to keep up with a lot of effect updates. I've been thinking about this for a bit, and I think that throttling should help this and still provide good effects tracking. At least, until there are Lua changes from SSG that improve this part of Lotro's Lua interfaces.

The image link didn't work, but that's fine as the issue was easily reproduced. Thanks a lot, Lisgrat!

Dreadweaver

Creepside version of this plugin would be greatly appreciated, tracking warg or spider debuffs or slows in a fight is invaluable.

Grimmerthan

I agree 100%. I think this, additional language support, and saving/loading DebuffVital setups for different fights are the top 3 things for me right now.

simplicity

Thank you for this much needed plugin, it is very useful.

I am struggling with the fact that the changes I make to the list of debuffs does not seem to save after I exit and re-open lotro. So each time I load the game, I have to re-set the plugin. Is it something I'm missing? Many thanks for taking the time to reply.