|
Category: Outdated LotRO InterfacesDPS Meter |
Interface Information |
|
Name: |
DPS Meter |
Author: |
|
Date: |
10-03-2010 05:06 PM |
Size: |
4.76 Kb |
Version: |
0.3 |
Rate File: |
|
It's a DPS meter. You'll need to copy Plugins\moebius92\DPSMeter\DPSMeter.vbs to
PluginData\<account name>\AllServers\ The VB Script will continually parse a
combat log and output the total amount of damage done by "You".
To actually use the DPS Meter, log into your character, and do the following:
1. Start logging your combat tab - make note of log file name.
2. Run the copy of DPSMeter.vbs in PluginData - open the combat log you've just created.
(if the common dialog isn't available, it might be a good idea to copy
the path and filename from the "Logging chat tab ..." message)
3. Load the DPSMeter plugin.
The top number is DPS, the bottom number is how long combat has been going on for.
You can drag the DPSMeter display around, it should store the location. If you unload
the DPSMeter plugin, you can reload it without mucking around with the combat tab logging
or DPSMeter.vbs. In order to stop DPSMeter.vbs, delete the combat log that it's reading.
This may throw a warning message - feel free to ignore. I'd've made exiting DPSMeter.vbs
cleaner, but I have no idea how.
It will also add a command /dpsmeter - there are three possible arguments:
/dpsmeter show - will show the DPS meter
/dpsmeter hide - will hide the DPS meter
/dpsmeter post - will show the DPS meter as long as you're not in combat.
I've actually found the last mode to be the least distracting.
Change History:
0.3 - Modified DPSMeter.vbs to do a one time back off on write failure
0.2 - Modified DPSMeter.vbs to use an InputBox if UserAccounts.CommonDialog is not available
0.1 - Original version
|
Archive List (Old Versions) |
File Name |
Version |
Size |
Author |
Date |
|
0.2 |
4.68 Kb |
moebius92 |
10-02-2010 09:27 PM |
|
0.1 |
4.30 Kb |
moebius92 |
10-01-2010 10:12 PM |
File Statistics |
User Rating: |
|
Downloads: |
22764 |
Views: |
118308 |
Favorites: |
9 |
Uploaded By: |
|
Last Modified: |
N/A |
|
| |
|
|
|
10-02-2010, 01:26 PM
|
|
The Undying
Forum posts: 22
File comments: 43
Uploads: 2
|
Great idea, a DPS meter
So I tried it out, but it doesn't work.
When running the VBS script file, I get the following error:
--------------------
Windows Script Host
Script: DPSMeter.vbs
Line: 1
Character: 1
Error: ActiveX-component cannot make object: 'UserAccounts.Commondialog'
Code: 800A01AD
Source: Runtimeerror Microsoft VBScript
--------------------
So I googled a bit and appears Windows 7 64-bit doesn't have the 'UserAccounts.Commondialog' API(?) anymore.
( http://kixtart.org/forums/ubbthreads...&Number=199282)
Can you change your script so I can select the combat file? Or can you make a variable where I can paste the filename in so I can run the plugin? I like to try it out
Cheers,
Ray
Ps. my localization setting is Dutch, so the error message above may not be exactly acurate (I translated the errormessage to English). But I think it should be like that
Last edited by Ray : 10-02-2010 at 01:27 PM.
|
|
|
10-03-2010, 02:50 AM
|
|
The Undying
Forum posts: 22
File comments: 43
Uploads: 2
|
V0.2 works
Thanks Moebius, version 0.2 works
Cheers,
Ray
|
|
|
10-03-2010, 10:40 AM
|
|
The Undying
Forum posts: 51
File comments: 44
Uploads: 15
|
Excellent. Thanks.
|
|
|
10-03-2010, 02:40 PM
|
|
The Wary
Forum posts: 0
File comments: 33
Uploads: 0
|
So maybe I'm not understanding how this works. I load the plugin in the client, start combat logging, then hit the vbs file in the plugindata, etc. directory. Once I do this, I immediately delete the combat log file, and stop logging in game. The first time I enter combat, I get the readout for DPS and the combat timer. After that first combat though, the DPS always reads zero (although the time continues to work properly). What am I missing? Is this only useful for a single fight? I can see that as a possibility, since maybe this was only designed for boss fights.
|
|
|
10-03-2010, 03:15 PM
|
|
The Wary
Forum posts: 0
File comments: 33
Uploads: 0
|
If I attempt to leave logging active, and keep DPSMeter.vbs running, I get an error on Line 76 Char 2 stating "The request operation cannot be performed on a file with a user-mapped section open." No clue.
|
|
|
10-03-2010, 06:09 PM
|
|
The Undying
Forum posts: 51
File comments: 44
Uploads: 15
|
Okay, you want to be doing the second thing (leaving logging going, keeping DPSMeter.vbs running) - the actual order of the start up steps should be:
1. Start combat tab logging.
2. Start DPSMeter.vbs
3. Start the DPSMeter plugin
I've modified DPSMeter.vbs so that it won't die horribly/throw error messages if it fails to write out the damage total. (It'll actually wait 10ms, try again, and if that fails, restart the read-write loop.) I expect there's two possible outcomes based on the error you were seeing, one okay, one bad.
First, it could end up eventually managing to write, so the DPSMeter should work, albeit with a slight delay (although the delay'll be measurable in milliseconds, so you probably won't notice.)
Second, whatever's opened the DPSMeter.plugindata file could never release it, in which case, it's not something I can solve - being able to forcably stop an external program from holding the file open is pretty much not something I can or should be able to do. If this is the case, DPSMeter will always think you're doing 0 damage, and never update. Again, if that happens, there's not really anything I can do. You can poke around and try to figure out what's keeping DPSMeter.plugindata open (it shouldn't be the LotRO client - the actual reads performed by the plugin are fairly brief, and only occur every 100 milliseconds or so), but it sounds like the most likely culprit is a virus checker scanning a file that's constantly being overwritten (a Google search suggests that the anti-virus AVG will causes similar sounding errors) , and it's probably not advisable to disable that.
|
|
|
10-03-2010, 06:17 PM
|
|
The Wary
Forum posts: 0
File comments: 33
Uploads: 0
|
I do have AVG, but I should be able to disable scanning on that specific file. Let me try your latest version and disabling scanning and we'll see what I get. I'll let you know either way. Thanks!
|
|
|
10-03-2010, 06:24 PM
|
|
The Wary
Forum posts: 0
File comments: 33
Uploads: 0
|
Well either your new version or me disabling "resident shield" for the "The Lord of the Rings Online" folder in "My Documents" solved the problem. GREAT plugin for a hunter. Look forward to further usability updates.
Thanks.
|
|
|
10-04-2010, 03:16 PM
|
|
The Undefeated
Forum posts: 8
File comments: 6
Uploads: 2
|
Couple of questions.
Admittedly, I haven't had the opportunity to download this or try it out. Also, I don't normally look at my combat text, but a couple of things crossed my mind when I saw this.
A. How well does does this perform? Does lag or computational time affect the accuracy of the plugin. If so, what kind of degree of error can we expect?
B. I don't have a loremaster but would their pet damage be included?
C. When does the meter start? If I'm on a dps class, my dps should not start when the tank rolls in and puts everyone in combat but when I actually begin attacking.
D. I notice some skills that hit more than one time appear to continue hitting and doing damage even though the target is dead. This may be just me though.
Thanks,
Grim
|
|
|
10-05-2010, 12:03 AM
|
|
The Undying
Forum posts: 51
File comments: 44
Uploads: 15
|
Re: Couple of questions.
A. Lag shouldn't be an issue. Total time is calculated via total time in combat, and is handled using the enter/leave combat events, so that should be accurate. Total damage done is read from the log files, so there may be a slight delay, but it's on the order of 100ms or so, I expect.
B. Nope - I only search for damage done by "You". I could improve this by actually reading in the entire combat log, instead of just reading in a damage done total, but that would be harder. Doable, but harder.
C. It starts when combat starts. I've got some issues with the traditional starting point of when the first damage is done, but really, the decision was made based on what I has available. I can accurate tell when combat starts, there's an event for that. I can somewhat less accurately tell when you first do some damage.
D. No, I've seen that too. It'll get counted for your damage total.
|
|
|
10-05-2010, 01:20 PM
|
|
The Wary
Forum posts: 0
File comments: 7
Uploads: 0
|
Being a mins how would this work if I'm healing and DPSing?
|
|
|
10-06-2010, 04:43 AM
|
|
The Wary
Forum posts: 0
File comments: 1
Uploads: 0
|
error when trying to load
I keep getting error Plugins\moebius92\DPSMeter\Main.lua:5: Unable to resolve package "Turbine.Utils". when I try to load the pluggin, is there something im doing wrong? I believe I have the damage read and combat text logging working though.
|
|
|
10-06-2010, 11:30 AM
|
|
The Undying
Forum posts: 51
File comments: 44
Uploads: 15
|
The meter just displays total damage done during the current combat divided by total time the current combat has lasted for. If you're splitting your attention between non-damaging activities and damaging activities, expect your DPS to commensurately lower.
As for the Turbine.Utils, it's available here. Sorry, I forgot to mention it. I'm used to using/having the basic Turbine Lua scripts available, and pretty much don't think about it any more.
|
|
|
10-06-2010, 02:16 PM
|
|
The Wary
Forum posts: 0
File comments: 48
Uploads: 1
|
Mind if I borrow some of your work
Last edited by vindalfur : 10-06-2010 at 03:01 PM.
|
|
|
10-06-2010, 06:11 PM
|
|
The Undying
Forum posts: 51
File comments: 44
Uploads: 15
|
Feel free.
I didn't really comment any of my code, so if you have questions, feel free to ask.
|
|
|
All times are GMT -5. The time now is 07:07 PM.
|
|